weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2066959313
> > > @JoaoJandre thanks for your review > > > the methods are moved from [HostTagDaoImpl.java](https://github.com/apache/cloudstack/blob/4.19/server/src/main/java/com/cloud/api/query/dao/HostTagDaoImpl.java) without any code changes. Since it has the very similar class name as [HostTagsDaoImpl](https://github.com/apache/cloudstack/blob/4.19/engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java), I merged them into 1 file. > > > > suggestion committed @JoaoJandre > > > > actually the test could be simple, as the all host tags are considered during vm deployment and vm migration, etc, including the implicit and current (explicit) host tags. > > @weizhouapache What happens if you define an implicit tag on a host and a flexible tag on it as well? > Currently you either have normal or flexible tags, not both. here is a question: why not both? the normal tag could be regarded as a special type of flexible tag. This PR will not break the flexible tags anyway, as the implicit tags are empty by default. It can be regarded as a limitation. I will update the doc PR. Anyone who is interested in supporting both implicit tags and flexible tags can work on the improvement to support both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
