weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2066918607
> @JoaoJandre thanks for your review > > the methods are moved from [HostTagDaoImpl.java](https://github.com/apache/cloudstack/blob/4.19/server/src/main/java/com/cloud/api/query/dao/HostTagDaoImpl.java) without any code changes. Since it has the very similar class name as [HostTagsDaoImpl](https://github.com/apache/cloudstack/blob/4.19/engine/schema/src/main/java/com/cloud/host/dao/HostTagsDaoImpl.java), I merged them into 1 file. suggestion committed @JoaoJandre actually the test could be simple, as the all host tags are considered during vm deployment and vm migration, etc, including the implicit and current (explicit) host tags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
