vishesh92 commented on code in PR #8643:
URL: https://github.com/apache/cloudstack/pull/8643#discussion_r1580864323
##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -2587,6 +2588,20 @@ private Pair<List<Long>, Integer>
searchForVolumeIdsAndCount(ListVolumesCmd cmd)
return new Pair<>(vmIds, count);
}
+ private void checkEncrypted(ListVolumesCmd cmd, List<Long> ids) {
Review Comment:
It's better to add a conditional check for this. This will result in getting
all the encrypted volumes from the database which can be an intensive operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
