JoaoJandre commented on PR #8985: URL: https://github.com/apache/cloudstack/pull/8985#issuecomment-2079269843
Hello @rohityadavcloud , @weizhouapache Looking briefly at this PR I noticed that it has a big intersection with #8782, especially the changes on the listVirtualMachines and listVirtualMachineMetrics APIs. When #8782 proposed to change the default behavior of them to not list the stats, both @weizhouapache and @rohityadavcloud were firmly against changing the default behavior (see https://github.com/apache/cloudstack/pull/8782#issuecomment-1995297443 and https://github.com/apache/cloudstack/pull/8782#issuecomment-1997341885). So now, only a month later, we get this PR: what is the big difference on these two PRs? And if there is, why not just propose an adjustment to #8782? In any case, this PR not only breaks compatibility on the APIs, but also changes the default value of another configuration; and all this is going into 4.18! Are we going to introduce breaking changes on a maintenance version? I would really like to understand what made you change your opinion on compatibility so fast. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
