rp- commented on code in PR #8889:
URL: https://github.com/apache/cloudstack/pull/8889#discussion_r1582586450
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/MultipathSCSIAdapterBase.java:
##########
@@ -223,15 +228,19 @@ public boolean disconnectPhysicalDisk(Map<String, String>
volumeToDisconnect) {
@Override
public boolean disconnectPhysicalDiskByPath(String localPath) {
LOGGER.debug(String.format("disconnectPhysicalDiskByPath(localPath)
called with args (%s) STARTED", localPath));
+ if (localPath == null || (localPath != null &&
!localPath.startsWith("/dev/mapper/"))) {
Review Comment:
Well `/dev/mapper` isn't just for multipath devices, it is for everything
the device mapper creates an entry.
e.g. every LVM block device.
And I could think of Linstor being used as shared LVM storage, were we don't
have `/dev/drbd*` paths and would get `/dev/mapper/*` entries as paths, but I
could check the Linstor database if the path belong to "us".
But anyway I think this is a shortcoming in CloudStack that it doesn't know
to which primary storage the device path belongs, and has to ask everyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
