rg9975 commented on code in PR #8889:
URL: https://github.com/apache/cloudstack/pull/8889#discussion_r1581627317
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/MultipathSCSIAdapterBase.java:
##########
@@ -223,15 +228,19 @@ public boolean disconnectPhysicalDisk(Map<String, String>
volumeToDisconnect) {
@Override
public boolean disconnectPhysicalDiskByPath(String localPath) {
LOGGER.debug(String.format("disconnectPhysicalDiskByPath(localPath)
called with args (%s) STARTED", localPath));
+ if (localPath == null || (localPath != null &&
!localPath.startsWith("/dev/mapper/"))) {
Review Comment:
Unfortunately, there is no other distinguishing factor I can think of in
this scenario to determine if the MultipathSCSIAdapter code should take action
or not. This flow is called when the LibvirtComputingResource cleans up disks
left over after a live migration (from what I can tell) and it only knows the
path that was referenced in the Domain configuration (the multipathed file).
/dev/mapper is the standard location for multipath mapped devices. Even if
another storage provider uses this path, this cleanup routine should not cause
an issue since it could logically only perform the same function (delete the
multipath and clean up any residual path devices left).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
