weizhouapache commented on code in PR #8994:
URL: https://github.com/apache/cloudstack/pull/8994#discussion_r1582644997


##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -1409,6 +1410,12 @@ private Pair<List<Long>, Integer> 
searchForUserVMIdsAndCount(ListVMsCmd cmd) {
         }
 
         Boolean isVnf = cmd.getVnf();
+        if (cmd instanceof ListVnfAppliancesCmd) {
+            if (isVnf != null && !isVnf) {
+                throw new InvalidParameterValueException("Unable to list VNF 
appliances as isvnf is set to false");
+            }
+            isVnf = true;
+        }

Review Comment:
   if `isVnf` is set to false, should throw an exception ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to