codecov-commenter commented on PR #6918: URL: https://github.com/apache/cloudstack/pull/6918#issuecomment-2099101527
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/6918?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `35.18519%` with `70 lines` in your changes are missing coverage. Please review. > Project coverage is 29.21%. Comparing base [(`e9ff270`)](https://app.codecov.io/gh/apache/cloudstack/commit/e9ff2707bbd58de8788da2397cfdd8e8a0ab44ff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`baf242e`)](https://app.codecov.io/gh/apache/cloudstack/pull/6918?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: Current head baf242e differs from pull request most recent head aec9305. Consider uploading reports for the commit aec9305 to get more accurate results | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/6918?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...a/com/cloud/network/dao/NetworkDetailsDaoImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&filepath=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fnetwork%2Fdao%2FNetworkDetailsDaoImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9uZXR3b3JrL2Rhby9OZXR3b3JrRGV0YWlsc0Rhb0ltcGwuamF2YQ==) | 29.72% | [25 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../cloud/configuration/ConfigurationManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fconfiguration%2FConfigurationManagerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbmZpZ3VyYXRpb24vQ29uZmlndXJhdGlvbk1hbmFnZXJJbXBsLmphdmE=) | 11.11% | [22 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../router/deployment/RouterDeploymentDefinition.java](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fnetwork%2Frouter%2Fdeployment%2FRouterDeploymentDefinition.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL25ldHdvcmsvcm91dGVyL2RlcGxveW1lbnQvUm91dGVyRGVwbG95bWVudERlZmluaXRpb24uamF2YQ==) | 45.45% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...in/java/com/cloud/server/ManagementServerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fserver%2FManagementServerImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3NlcnZlci9NYW5hZ2VtZW50U2VydmVySW1wbC5qYXZh) | 20.00% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...dstack/api/command/admin/config/ListCfgsByCmd.java](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&filepath=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fcommand%2Fadmin%2Fconfig%2FListCfgsByCmd.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9jb21tYW5kL2FkbWluL2NvbmZpZy9MaXN0Q2Znc0J5Q21kLmphdmE=) | 33.33% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...oudstack/api/command/admin/config/ResetCfgCmd.java](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&filepath=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fcommand%2Fadmin%2Fconfig%2FResetCfgCmd.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9jb21tYW5kL2FkbWluL2NvbmZpZy9SZXNldENmZ0NtZC5qYXZh) | 33.33% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...udstack/api/command/admin/config/UpdateCfgCmd.java](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&filepath=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fcommand%2Fadmin%2Fconfig%2FUpdateCfgCmd.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9jb21tYW5kL2FkbWluL2NvbmZpZy9VcGRhdGVDZmdDbWQuamF2YQ==) | 33.33% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [ui/src/components/view/SettingsTab.vue](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&filepath=ui%2Fsrc%2Fcomponents%2Fview%2FSettingsTab.vue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL2NvbXBvbmVudHMvdmlldy9TZXR0aW5nc1RhYi52dWU=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [ui/src/config/section/network.js](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&filepath=ui%2Fsrc%2Fconfig%2Fsection%2Fnetwork.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dWkvc3JjL2NvbmZpZy9zZWN0aW9uL25ldHdvcmsuanM=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## main #6918 +/- ## ============================================= + Coverage 15.28% 29.21% +13.93% - Complexity 11528 30491 +18963 ============================================= Files 5425 5101 -324 Lines 474072 358887 -115185 Branches 57689 52378 -5311 ============================================= + Hits 72466 104861 +32395 + Misses 393554 239612 -153942 - Partials 8052 14414 +6362 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/6918/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/6918/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `25.18% <36.53%> (?)` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/6918/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.84% <0.00%> (+0.57%)` | :arrow_up: | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/6918/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.50% <12.94%> (?)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/6918/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/6918?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
