rohityadavcloud commented on code in PR #9108:
URL: https://github.com/apache/cloudstack/pull/9108#discussion_r1610130733
##########
framework/config/src/test/java/org/apache/cloudstack/framework/config/ConfigKeyScheduledExecutionWrapperTest.java:
##########
@@ -59,8 +58,8 @@ public void nullConfigKeyTest() {
@Test(expected = IllegalArgumentException.class)
public void invalidConfigKeyTest() {
TestRunnable runnable = new TestRunnable();
- ConfigKey<String> configKey = Mockito.mock(ConfigKey.class);
- when(configKey.value()).thenReturn("test");
+ ConfigKey<String> configKey = new ConfigKey<>(String.class, "test",
"test", "test", "test", true,
+ ConfigKey.Scope.Global, null, null, null, null, null,
ConfigKey.Kind.CSV, null);
Review Comment:
I think the original test (before Wei's change) was just testing for an
invalid configKey; I reverted the change to keep author's original intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
