JoaoJandre commented on code in PR #7226:
URL: https://github.com/apache/cloudstack/pull/7226#discussion_r1612153554
##########
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java:
##########
@@ -2667,9 +2667,13 @@ public Pair<VirtualDisk, String> getDiskDevice(String
vmdkDatastorePath) throws
}
// return pair of VirtualDisk and disk device bus name(ide0:0, etc)
- public Pair<VirtualDisk, String> getDiskDevice(String vmdkDatastorePath,
boolean matchExactly) throws Exception {
+ public Pair<VirtualDisk, String> getDiskDevice(String vmdkDatastorePath,
boolean matchExactly, boolean discardDot) throws Exception {
Review Comment:
```suggestion
public Pair<VirtualDisk, String> getDiskDevice(String vmdkDatastorePath,
boolean matchExactly, boolean ignoreDotOnPath) throws Exception {
```
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -5055,6 +5069,29 @@ private Answer execute(MigrateVolumeCommand cmd) {
volumePath = vmMo.getVmdkFileBaseName(disk);
}
}
+ if (cmd.getNewIops() != null) {
+ String vmwareDocumentation =
"https://kb.vmware.com/s/article/68164";;
Review Comment:
@SadiJr @BryanMLima I think that what @weizhouapache meant is that: if you
have a volume using a disk offering with a given IOPS limitation and change the
offering to one without IOPS limits, since this code only executes for IOPS !=
null, the volume will not have its IOPS updated, it will stay with the old
value. To me it also looks like this will be the case.
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1229,8 +1229,8 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws
ResourceAllocationExcep
validateIops(newMinIops, newMaxIops, volume.getPoolType());
} else {
- newMinIops = newDiskOffering.getMinIops();
- newMaxIops = newDiskOffering.getMaxIops();
+ newMinIops = newDiskOffering.getMinIops() != null ?
newDiskOffering.getMinIops() : newDiskOffering.getIopsReadRate();
+ newMaxIops = newDiskOffering.getMaxIops() != null ?
newDiskOffering.getMaxIops() : newDiskOffering.getIopsWriteRate();
Review Comment:
why get read/write rate if the min/max are null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
