gpordeus opened a new pull request, #9227:
URL: https://github.com/apache/cloudstack/pull/9227

   ### Description
   
   This PR simply adds the fields of `diskbytesreadratemax` and 
`diskbyteswriteratemax` to the `Add Disk Offering` form and to the Disk 
Offering details in the GUI.
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   
   ### Screenshots (if appropriate):
   <details>
   <summary>Add Disk Offering window</summary>
   
   
![image](https://github.com/apache/cloudstack/assets/22242548/f6b28c66-4b3e-4148-94aa-7ca17916cc35)
   </details>
   
   <details>
   <summary>Disk Offering details</summary>
   
   
![image](https://github.com/apache/cloudstack/assets/22242548/e2554e00-c0c9-424f-b7d7-218f684de07c)
   </details>
   
   
   ### How Has This Been Tested?
   I created the offering with the readrate, writerate, readratemax and 
writeratemax and verified their presence in the created offering's details.
   
   Trying to put a max value smaller than the base rate results in the API 
error:
   
![image](https://github.com/apache/cloudstack/assets/22242548/074f6110-5734-4811-b2d3-f38ab2cf125b)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to