sureshanaparti commented on code in PR #9224:
URL: https://github.com/apache/cloudstack/pull/9224#discussion_r1635862036
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -564,7 +567,7 @@ private boolean validateVolume(Account caller, long
ownerId, Long zoneId, String
_resourceLimitMgr.checkResourceLimit(_accountMgr.getAccount(ownerId),
ResourceType.secondary_storage);
}
- sanitizeFormat(format);
+ checkFormatWithSupportedHypervisorsInZone(format, zoneId);
Review Comment:
yes @DaanHoogland, it's called before. this is duplicate call. so removed
https://github.com/apache/cloudstack/blob/edf7394919fa29b2e0c2ebec5b624b5dde7dedf6/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java#L413
https://github.com/apache/cloudstack/blob/edf7394919fa29b2e0c2ebec5b624b5dde7dedf6/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java#L455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
