harikrishna-patnala commented on issue #8946: URL: https://github.com/apache/cloudstack/issues/8946#issuecomment-2164862435
@nischalnischal2020 please check the newly created PR #9239 to address an issue which I've observed while checking your issue here. The issue I've observed is not while taking the snapshot but while creating the template from the snapshot (stack trace also refers the same). I could not reproduce the original issue of failed snapshot showing as backedup state rather than error (it might have already fixed after 4.17.2), but I saw another serious issue. The issue is whenever a snapshot is used to create a template or volume and if there is failure in backing up the snapshot to the secondary store and as part of handling that failure MS is deleting the snapshot in primary storage itself. These changes are introduced as part of the PR https://github.com/apache/cloudstack/pull/5297 Create a snapshot of a volume (set snapshot.backup.to.secondary = False) Create a template from that snapshot As part of the creation, MS first tries to backup the snapshot to the secondary storage I've made it fail MS recognized the failure and as part of failure it is deleting the snapshot on the primary storage (also marking the snapshot_store_ref entry for primary store role as "Destroyed") -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
