(cloudstack) branch 4.19 updated: fix assignvm template permission check (#8886)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.19 by this push:
     new 083ac069ca4 fix assignvm template permission check (#8886)
083ac069ca4 is described below

commit 083ac069ca47a8f96ed9306994e5fbe66352ebc0
Author: Gabriel Pordeus Santos <gabriel.san...@scclouds.com.br>
AuthorDate: Fri Jun 21 05:58:46 2024 -0300

    fix assignvm template permission check (#8886)
---
 server/src/main/java/com/cloud/vm/UserVmManagerImpl.java | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java 
b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
index f68b3a6237a..9f0adf9d5fd 100644
--- a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
+++ b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
@@ -7223,10 +7223,7 @@ public class UserVmManagerImpl extends ManagerBase 
implements UserVmManager, Vir
         if (template == null) {
             throw new InvalidParameterValueException(String.format("Template 
for VM: %s cannot be found", vm.getUuid()));
         }
-        if (!template.isPublicTemplate()) {
-            Account templateOwner = 
_accountMgr.getAccount(template.getAccountId());
-            _accountMgr.checkAccess(newAccount, null, true, templateOwner);
-        }
+        _accountMgr.checkAccess(newAccount, AccessType.UseEntry, true, 
template);
 
         // VV 5: check the new account can create vm in the domain
         DomainVO domain = _domainDao.findById(cmd.getDomainId());