sureshanaparti commented on code in PR #8236:
URL: https://github.com/apache/cloudstack/pull/8236#discussion_r1650106414
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LinkAccountToLdapCmd.java:
##########
@@ -63,9 +64,12 @@ public class LinkAccountToLdapCmd extends BaseCmd {
@Parameter(name = ApiConstants.ADMIN, type = CommandType.STRING, required
= false, description = "domain admin username in LDAP ")
private String admin;
- @Parameter(name = ApiConstants.ACCOUNT_TYPE, type = CommandType.INTEGER,
required = true, description = "Type of the account to auto import. Specify 0
for user and 2 for "
+ @Parameter(name = ApiConstants.ACCOUNT_TYPE, type = CommandType.INTEGER,
required = false, description = "Type of the account to auto import. Specify 0
for user and 2 for "
+ "domain admin")
- private int accountType;
+ private Integer accountType;
+
+ @Parameter(name = ApiConstants.ROLE_ID, type = CommandType.UUID,
entityType = RoleResponse.class, required = false, description = "Creates the
account under the specified role.", since="4.20.0")
Review Comment:
```suggestion
@Parameter(name = ApiConstants.ROLE_ID, type = CommandType.UUID,
entityType = RoleResponse.class, required = false, description = "Creates the
account under the specified role.", since="4.19.1")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
