sureshanaparti commented on code in PR #9283:
URL: https://github.com/apache/cloudstack/pull/9283#discussion_r1650125992


##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -506,6 +506,10 @@ public class ConfigurationManagerImpl extends ManagerBase 
implements Configurati
     public static final ConfigKey<Boolean> 
ALLOW_DOMAIN_ADMINS_TO_CREATE_TAGGED_OFFERINGS = new ConfigKey<>(Boolean.class, 
"allow.domain.admins.to.create.tagged.offerings", "Advanced",
             "false", "Allow domain admins to create offerings with tags.", 
true, ConfigKey.Scope.Account, null);
 
+    public static final ConfigKey<Long> DELETE_BATCH_QUERY_SIZE = new 
ConfigKey<>("Advanced", Long.class, "delete.batch.query.size", "0",
+            "Indicates the limit applied while deleting entries in bulk. With 
this, ACS will run the delete query, applying the limit, as many times as 
necessary" +
+            " to delete all the entries. Zero (0) means that no limit will be 
applied, therefore, the query will run once and without limit, keeping the 
default behavior.", true);
+

Review Comment:
   @vishesh92 Add upgrade path to change config name` 
vm.stats.remove.batch.size` => `delete.batch.query.size`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to