shwstppr commented on code in PR #9305:
URL: https://github.com/apache/cloudstack/pull/9305#discussion_r1686241177


##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -7229,7 +7232,8 @@ public VirtualMachine 
migrateVirtualMachineWithVolume(Long vmId, Host destinatio
             throw new 
InvalidParameterValueException(String.format("Unsupported hypervisor: %s for VM 
migration, we support XenServer/VMware/KVM only", vm.getHypervisorType()));
         }
 
-        if (_vmSnapshotDao.findByVm(vmId).size() > 0) {
+        if 
(!VM_STORAGE_MIGRATION_WITH_SUPPORTING_SUPPORTING_HYPERVISORS.contains(vm.getHypervisorType())
 &&

Review Comment:
   ```suggestion
           if 
(!VM_STORAGE_MIGRATION_WITH_SNAPSHOTS_SUPPORTING_HYPERVISORS.contains(vm.getHypervisorType())
 &&
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to