Pearl1594 commented on code in PR #9410:
URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686629136
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##########
@@ -839,7 +848,7 @@ private void
validateManagedKubernetesClusterCreateParameters(final CreateKubern
}
private Network getKubernetesClusterNetworkIfMissing(final String
clusterName, final DataCenter zone, final Account owner, final int
controlNodesCount,
- final int nodesCount, final String
externalLoadBalancerIpAddress, final Long networkId) throws
CloudRuntimeException {
+ final int nodesCount, final String
externalLoadBalancerIpAddress, final Long networkId, final Long asNumber)
throws CloudRuntimeException {
Review Comment:
@weizhouapache when we use a pre-existing network to deploy a CKS cluster,
and the network has an offering that accepts AS number ,then we wouldn't pass
as number during CKS cluster creation. But, when we set a network offering in
the global setting that requires an AS number (i.e., specify AS number is true)
and we want to create an isolated network during CKS cluster creation, then we
rely on the AS number to be passed during the cluster creation phase. This
would ultimately be used when creating the network. So effectively, AS number
is a parameter of the network and not CKS .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
