weizhouapache commented on code in PR #9410:
URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686769179
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##########
@@ -839,7 +848,7 @@ private void
validateManagedKubernetesClusterCreateParameters(final CreateKubern
}
private Network getKubernetesClusterNetworkIfMissing(final String
clusterName, final DataCenter zone, final Account owner, final int
controlNodesCount,
- final int nodesCount, final String
externalLoadBalancerIpAddress, final Long networkId) throws
CloudRuntimeException {
+ final int nodesCount, final String
externalLoadBalancerIpAddress, final Long networkId, final Long asNumber)
throws CloudRuntimeException {
Review Comment:
yes, the checks I can remember are
- on AS number if specifyasnumber is true
- on vlan if specifyvlan is true
- on gateway/netmask if network mode is ROUTED
there may be more.
it would be better if we can re-use the checks in
https://github.com/apache/cloudstack/blob/d41dc17b2c2d89c878472c636aa38bb015950927/server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L1441-L1750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
