nvazquez commented on code in PR #9410:
URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1691749226
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##########
@@ -839,7 +848,7 @@ private void
validateManagedKubernetesClusterCreateParameters(final CreateKubern
}
private Network getKubernetesClusterNetworkIfMissing(final String
clusterName, final DataCenter zone, final Account owner, final int
controlNodesCount,
- final int nodesCount, final String
externalLoadBalancerIpAddress, final Long networkId) throws
CloudRuntimeException {
+ final int nodesCount, final String
externalLoadBalancerIpAddress, final Long networkId, final Long asNumber)
throws CloudRuntimeException {
Review Comment:
Ok @weizhouapache @Pearl1594 - we can revert the changes as they were to
assign an AS number only in case network was not provided and CKS needed to
create it, and also the offering supported Specify AS number and Dynamic Routing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
