sureshanaparti commented on code in PR #9270:
URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1719295762
##########
server/src/main/java/com/cloud/storage/snapshot/SnapshotManager.java:
##########
@@ -58,6 +54,12 @@ public interface SnapshotManager extends Configurable {
public static final ConfigKey<Boolean> VmStorageSnapshotKvm = new
ConfigKey<>(Boolean.class, "kvm.vmstoragesnapshot.enabled", "Snapshots",
"false", "For live snapshot of virtual machine instance on KVM hypervisor
without memory. Requieres qemu version 1.6+ (on NFS or Local file system) and
qemu-guest-agent installed on guest VM", true, ConfigKey.Scope.Global, null);
+ ConfigKey<Boolean> kvmIncrementalSnapshot = new ConfigKey<>(Boolean.class,
"kvm.incremental.snapshot", "Snapshots", "false", "Whether differential
snapshots are enabled for" +
+ " KVM or not. When this is enabled, all KVM snapshots will be
incremental. Bear in mind that it will generate a new full snapshot when the
snapshot chain reaches the limit defined in snapshot.delta.max.", true,
ConfigKey.Scope.Cluster, null);
+
+ ConfigKey<Integer> snapshotDeltaMax = new ConfigKey<>(Integer.class,
"snapshot.delta.max", "Snapshots", "16", "Max delta snapshots between two full
snapshots. " +
+ "Only valid for KVM and XenServer.", true, ConfigKey.Scope.Global,
null);
+
Review Comment:
It's better to have both these configs with the same scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
