sureshanaparti commented on code in PR #9270:
URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1719305288


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePool.java:
##########
@@ -92,6 +92,8 @@ public default KVMPhysicalDisk createPhysicalDisk(String 
volumeUuid, PhysicalDis
 
     public Map<String, String> getDetails();
 
+    String getLocalPathFor(String relativePath);

Review Comment:
   ```suggestion
       default String getLocalPathFor(String relativePath) {
           return String.format("%s%s%s", getLocalPath(), File.separator, 
relativePath);
       }
   ```
   
   add default implementation , and remove overrides with similar implementation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to