weizhouapache commented on code in PR #9564:
URL: https://github.com/apache/cloudstack/pull/9564#discussion_r1725182716
##########
engine/components-api/src/main/java/com/cloud/storage/StorageManager.java:
##########
@@ -174,8 +174,8 @@ public interface StorageManager extends StorageService {
"If set to true, the disk is created only when there is a suitable
storage pool that supports the disk provisioning type specified by the
service/disk offering. " +
"If set to false, the disk is created with a disk
provisioning type supported by the pool. Default value is false, and this is
currently supported for VMware only.",
true, ConfigKey.Scope.Zone);
- ConfigKey<String> PreferredStoragePool = new
ConfigKey<String>(String.class, "preferred.storage.pool", "Advanced", "",
- "The UUID of preferred storage pool for allocation.", true,
ConfigKey.Scope.Account, null);
+ ConfigKey<String> PreferredStoragePool = new ConfigKey<>(String.class,
"preferred.storage.pool", "Advanced", "",
Review Comment:
I wonder if we can have two configurations with same key
- 1 for global/zone/cluster
- 2 for global/domain/account
changing from Account to Cluster may be disliked by some users (maybe)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
