Re: [PR] UI: Fix VPC network offerings listing on VPC tier creation [cloudstack]

[via GitHub]

kiranchavala commented on PR #9557:
URL: https://github.com/apache/cloudstack/pull/9557#issuecomment-2304320896

   > > @DaanHoogland @weizhouapache I've revisited the logic and got the 
following results:
   > > For Public LB VPC: <img alt="Screenshot 2024-08-22 at 01 17 44" 
width="821" 
src="https://private-user-images.githubusercontent.com/5295080/360283988-0e85ae33-0512-4796-a848-7066da058bf3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMTE3NzYsIm5iZiI6MTcyNDMxMTQ3NiwicGF0aCI6Ii81Mjk1MDgwLzM2MDI4Mzk4OC0wZTg1YWUzMy0wNTEyLTQ3OTYtYTg0OC03MDY2ZGEwNThiZjMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjJUMDcyNDM2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDUwNDRjMjMyODUwNTYwMTk3YTU4NjBkMjAwZTdkZGFiOGQ0YTY1MWJkZjQ3YzUzYzIxZWQwZGE1MDdiMWRlNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.rsFHQKxSv-Sslm3rvgAM7J1SXtAdcGMp9ZPH4rd8P_Y";>
   > > For Internal LB VPC: <img alt="Screenshot 2024-08-22 at 01 18 43" 
width="821" 
src="https://private-user-images.githubusercontent.com/5295080/360284190-33bface4-41de-431f-99be-590c6907c47e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMTE3NzYsIm5iZiI6MTcyNDMxMTQ3NiwicGF0aCI6Ii81Mjk1MDgwLzM2MDI4NDE5MC0zM2JmYWNlNC00MWRlLTQzMWYtOTliZS01OTBjNjkwN2M0N2UucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjJUMDcyNDM2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDkxYzgyOWY4MzJkZGVlZGE1ZGZiODIzNjliNDU4NjdhYzhjZWUyYTAzOTNiMzczNWJhNDkxNDg3NzM5ODRmMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Z8eMR6bFBxN5t2uTVtKNyURz2GJRZmge3tmpHu5o18c";>
   > > Can you please review the latest changes?
   > 
   > @nvazquez does the env have the network offering 
`DefaultIsolatedNetworkOfferingForVpcNetworksNoLB` (Offering for Isolated Vpc 
networks with Source Nat service enabled and LB service Disabled) ?
   > 
   > if yes, I think it should be in the list as well.
   
   @weizhouapache 
   
   
   The vpc networks are created from vpc offerings which have LB of either 
vpcvrouter and internalLBVM
   
   <img width="665" alt="Screenshot 2024-08-22 at 3 57 12 PM" 
src="https://github.com/user-attachments/assets/984882a2-b82f-4685-b42b-cec2e86877cf";>
   
   so i believe "DefaultIsolatedNetworkOfferingForVpcNetworksNoLB" should not 
be displayed 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org