weizhouapache commented on PR #9557: URL: https://github.com/apache/cloudstack/pull/9557#issuecomment-2301789967
> Thanks for reviewing @DaanHoogland @weizhouapache - before the fix the network offerings listing was passing `supportedServices=SourceNat`, and the solution I found was passing `supportedServices=SourceNat,Lb` in case the VPC offering supports the Lb service. Maybe this is the wrong approach, what do you think/suggest? as I understand - good: VPC uses public LB (it supports internal LB as well), network uses internal LB - good: VPC uses public LB (it supports internal LB as well), network uses public LB - good: VPC uses public LB (it supports internal LB as well), network does not use LB - not good: VPC uses internal LB, network uses public LB - good: VPC uses internal LB, network uses internal LB - good: VPC uses internal LB, network does not use LB I think network offerings should be filtered by the LB service provider (VpcVirtualRouter or InternalLbVm) instead of service (Lb). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
