shwstppr commented on code in PR #9574:
URL: https://github.com/apache/cloudstack/pull/9574#discussion_r1728426044
##########
engine/schema/src/main/java/com/cloud/network/as/dao/AutoScaleVmGroupVmMapDaoImpl.java:
##########
@@ -67,7 +67,7 @@ public int countAvailableVmsByGroup(long vmGroupId) {
SearchCriteria<Integer> sc = CountBy.create();
sc.setParameters("vmGroupId", vmGroupId);
sc.setJoinParameters("vmSearch", "states",
- State.Starting, State.Running, State.Stopping,
State.Migrating);
+ State.Starting, State.Running, State.Stopping,
State.Migrating, State.Error, State.Stopped);
Review Comment:
This may make autoscaler to not retry deployment if any deployment goes into
error state intermittently. Should we include Error state after some n reties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
