vishesh92 commented on code in PR #9633:
URL: https://github.com/apache/cloudstack/pull/9633#discussion_r1746651965
##########
engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql:
##########
@@ -239,3 +239,6 @@ INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid,
hypervisor_type, hyp
INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type,
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined)
SELECT UUID(),'VMware', '8.0.2', guest_os_name, guest_os_id, utc_timestamp(), 0
FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND
hypervisor_version='8.0';
INSERT IGNORE INTO `cloud`.`hypervisor_capabilities` (uuid, hypervisor_type,
hypervisor_version, max_guests_limit, security_group_enabled,
max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported,
vm_snapshot_enabled) values (UUID(), 'VMware', '8.0.3', 1024, 0, 59, 64, 1, 1);
INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type,
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined)
SELECT UUID(),'VMware', '8.0.3', guest_os_name, guest_os_id, utc_timestamp(), 0
FROM `cloud`.`guest_os_hypervisor` WHERE hypervisor_type='VMware' AND
hypervisor_version='8.0';
+
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vm_instance', 'delete_protection',
'boolean DEFAULT FALSE COMMENT "delete protection for vm" ');
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.volumes', 'delete_protection',
'boolean DEFAULT FALSE COMMENT "delete protection for volumes" ');
Review Comment:
I don't think it will create a lot of impact. Just a few extra queries to
check the value from details table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
