DaanHoogland commented on code in PR #9498:
URL: https://github.com/apache/cloudstack/pull/9498#discussion_r1770880307
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##########
@@ -637,6 +639,39 @@ public KVMPhysicalDisk getPhysicalDisk(String volumeUuid,
KVMStoragePool pool) {
}
}
+ /**
+ * adjust refcount
+ */
+ private int adjustStoragePoolRefCount(String uuid, int adjustment) {
+ synchronized (uuid) {
Review Comment:
Yes @JoaoJandre we should, as we use a (concurrent)Hashmap with the uuid as
key, but you are right, maybe we should first retrieve the key by key from the
hasjmap and use that...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
