abh1sar commented on code in PR #9773:
URL: https://github.com/apache/cloudstack/pull/9773#discussion_r1794737187
##########
ui/src/config/section/storage.js:
##########
@@ -165,9 +165,10 @@ export default {
label: 'label.action.take.snapshot',
dataView: true,
show: (record, store) => {
- return record.state === 'Ready' && (record.hypervisor !== 'KVM' ||
- record.hypervisor === 'KVM' && record.vmstate === 'Running' &&
store.features.kvmsnapshotenabled ||
- record.hypervisor === 'KVM' && record.vmstate !== 'Running')
+ return record.state === 'Ready' &&
+ (record.hypervisor !== 'KVM' ||
+ ['Stopped', 'Destroyed'].includes(record.vmstate) ||
Review Comment:
Before this change, the button would be shown for all states part from
'Running'.
Now it will only be shown for 'Stopped' or 'Destroyed' states
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
