rohityadavcloud commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2507223580
@Dav-11 to answer your questions, in addition to what Guto has already advised; * Adding new fields is acceptable to existing APIs, you can also make some fields/parameters of an API non-required or required depending on your use-case * If there are fields which may not be necessary, we mustn't delete them but * More general note: the VPN related APIs may accept the VPN provider (or similar) as an option, so the end user can specify which type of VPN they want; or this could be a property of the network where this is set (think updateNetwork? or a new API to configure/list VPN provider for the network). You want to explore an option that's intuitive and can then allow to support this easily in the UI. * Feel free to re-open a new PR or rework this one, this is all up to you. Here are few more links for you that you may find useful from the open source [hackerbook](https://github.com/shapeblue/hackerbook/tree/main) (CloudStack self-learning course material): https://github.com/shapeblue/hackerbook/blob/main/2-dev.md#contributing-to-cloudstack https://github.com/shapeblue/hackerbook/blob/main/hack/framework.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
