bernardodemarco commented on code in PR #10115:
URL: https://github.com/apache/cloudstack/pull/10115#discussion_r1890985082


##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -827,6 +829,10 @@ private Pair<List<UserAccountJoinVO>, Integer> 
getUserListInternal(Account calle
             }
         }
 
+        if (userSource != null) {
+            sc.setParameters("userSource", userSource.toString());
+        }

Review Comment:
   If the `setParametersIfNotNull` method were used, scenarios where 
`userSource` is `null` would result in an NPE because the `toString` method of 
the enum is invoked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to