JoaoJandre commented on PR #9132: URL: https://github.com/apache/cloudstack/pull/9132#issuecomment-2559449568
> @GaOrtiga @FelipeM525 @JoaoJandre , @jbampton is the only native english speaker active on this ticket. As contributor we have are specialities and as coders we get to decide on coding stardards, but not on English language standards, so I suggest we go with @jbampton 's suggestions where it come to log messages. What do you guys think? @DaanHoogland, what @FelipeM525 and @GaOrtiga were pointing out in this comment https://github.com/apache/cloudstack/pull/9132#discussion_r1713813784, is that, in some changed lines, the **abbreviation** (it is not an acronym) ID is left as `Id` (such as in line 106 of `api/src/main/java/org/apache/cloudstack/api/command/admin/internallb/StartInternalLBVMCmd.java`), whereas in other lines, it is changed to `ID` (such as line 137 of `plugins/network-elements/juniper-contrail/src/main/java/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java`). I agree that the correct abbreviation is ID, and not Id, and thus, my suggestion is to change **all** occurrences of Id to ID (at least in the lines that this PR is touching). In any case, I would refrain from going for "argumentum ad verecundiam", as this is not a healthy way of solving conflicts in a community. @jbampton may be a native speaker, but he is not perfect, and non-native speakers may catch errors in his English nonetheless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
