iishitahere commented on code in PR #10109:
URL: https://github.com/apache/cloudstack/pull/10109#discussion_r1900349014
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/network/VmwareTrafficLabel.java:
##########
@@ -120,4 +126,8 @@ public void setVirtualSwitchName(String vSwitchName) {
public void setVirtualSwitchType(VirtualSwitchType vSwitchType) {
_vSwitchType = vSwitchType;
}
+
+ // Getter to ensure traffic shaping consistency across all NICs
Review Comment:
> Where and how is your variable used, at all?
Hi @rohityadavcloud ,
I hope you’re doing well. I wanted to inform you that I will be working on
my PR again, as I’ve encountered some issues related to the changes made.
Specifically, I am addressing the problem with the vm.network.throttling.rate
configuration in the cloud.configuration table.
PR Summary:
This PR adds a default value for the vm.network.throttling.rate parameter,
which specifies the default data transfer rate allowed for user VMs’ default
network (200 Mbps). Additionally, the PR removes the deprecated
guest.ip.network and guest.netmask configuration entries.
Here’s what was changed:
Inserted a new entry: vm.network.throttling.rate with a default value of 200
Mbps.
Removed old entries: guest.ip.network and guest.netmask.
Updated the relevant code references.
A new branch (fix-vm-network-throttling-rate) was created to implement these
changes.
I’ll be addressing the feedback and making necessary fixes to ensure the PR
passes. Thank you for your patience.
Best regards,
Ishita
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
