DaanHoogland commented on code in PR #8575:
URL: https://github.com/apache/cloudstack/pull/8575#discussion_r1910197430
##########
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/motion/StorPoolDataMotionStrategy.java:
##########
@@ -219,24 +219,23 @@ public void copyAsync(DataObject srcData, DataObject
destData, Host destHost,
} else {
answer = (CopyCmdAnswer) ep2.sendMessage(backupSnapshot);
if (answer != null && answer.getResult()) {
- SpApiResponse resSnapshot =
StorPoolUtil.volumeFreeze(volumeName, conn);
+ SpApiResponse resSnapshot =
StorPoolUtil.volumeSnapshot(volumeName, template.getUuid(), null, "template",
null, conn);
if (resSnapshot.getError() != null) {
- logger.debug("Could not snapshot volume [id: {},
name: {}]", snapshot.getId(), snapshot.getName());
- StorPoolUtil.spLog("Volume freeze failed with
error=%s", resSnapshot.getError().getDescr());
+ logger.debug(String.format("Could not snapshot
volume with ID=%s", snapshot.getId()));
Review Comment:
why revert to the old style logging?
```suggestion
logger.debug("Could not snapshot volume with
ID={}", snapshot.getId());
```
should work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
