abh1sar commented on code in PR #10140:
URL: https://github.com/apache/cloudstack/pull/10140#discussion_r1918189120
##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -273,10 +292,62 @@ public boolean deleteBackupOffering(final Long
offeringId) {
throw new CloudRuntimeException("Backup offering is assigned to
VMs, remove the assignment(s) in order to remove the offering.");
}
- validateForZone(offering.getZoneId());
+ validateBackupForZone(offering.getZoneId());
return backupOfferingDao.remove(offering.getId());
}
+ @Override
+ public Map<String, String> getVmDetailsForBackup(VirtualMachine vm) {
+ HashMap<String, String> details = new HashMap<>();
+ details.put(ApiConstants.HYPERVISOR,
vm.getHypervisorType().toString());
+ ServiceOffering serviceOffering =
entityManager.findById(ServiceOffering.class, vm.getServiceOfferingId());
Review Comment:
No, will use the respective Daos.
##########
plugins/backup/networker/src/main/java/org/apache/cloudstack/backup/NetworkerBackupProvider.java:
##########
@@ -117,6 +122,12 @@ public class NetworkerBackupProvider extends AdapterBase
implements BackupProvid
@Inject
private VMInstanceDao vmInstanceDao;
+ @Inject
+ private EntityManager entityManager;
Review Comment:
will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
