abh1sar commented on code in PR #10140:
URL: https://github.com/apache/cloudstack/pull/10140#discussion_r1918164498
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -6139,6 +6186,11 @@ public UserVm createVirtualMachine(DeployVMCmd cmd)
throws InsufficientCapacityE
}
}
+ List<DiskOfferingInfo> dataDiskOfferingsInfo =
cmd.getDataDiskOfferingsInfo();
+ if (dataDiskOfferingsInfo != null && diskOfferingId != null) {
Review Comment:
diskOfferingId also corresponds to root disk if vm is created from iso.
It is definitely better if we have a single argument for all data disk
creation, but we can't avoid passing diskOfferingId to other methods due to the
iso limitation.
I can check the ISO condition and put the diskoffering details for single
data disk in diskOfferingInfoList if you think it is still worth doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
