Pearl1594 commented on code in PR #10215:
URL: https://github.com/apache/cloudstack/pull/10215#discussion_r1924702635
##########
ui/src/views/dashboard/CapacityDashboard.vue:
##########
@@ -184,15 +190,19 @@
</div>
<a-progress
status="active"
- :percent="statsMap[ctype]?.capacitytotal > 0 ? parseFloat(100.0
* statsMap[ctype]?.capacityused / statsMap[ctype]?.capacitytotal) : 0"
- :format="p => statsMap[ctype]?.capacitytotal > 0 ?
parseFloat(100.0 * statsMap[ctype]?.capacityused /
statsMap[ctype]?.capacitytotal).toFixed(2) + '%' : '0%'"
+ :percent="statsMap[ctype]?.capacitytotal > 0 ?
+ this.displayAllocatedCompute ? parseFloat(100.0 *
statsMap[ctype]?.capacityallocated / statsMap[ctype]?.capacitytotal) :
parseFloat(100.0 * statsMap[ctype]?.capacityused /
statsMap[ctype]?.capacitytotal)
+ : 0"
+ :format="p => statsMap[ctype]?.capacitytotal > 0 ?
+ this.displayAllocatedCompute ? parseFloat(100.0 *
statsMap[ctype]?.capacityallocated / statsMap[ctype]?.capacitytotal).toFixed(2)
+ '%' : parseFloat(100.0 * statsMap[ctype]?.capacityused /
statsMap[ctype]?.capacitytotal).toFixed(2) + '%'
+ : '0%'"
stroke-color="#52c41a"
size="small"
style="width:95%; float: left"
/>
<br/>
<div style="text-align: center">
- {{ displayData(ctype, statsMap[ctype]?.capacityused) }} {{
$t('label.allocated') }} | {{ displayData(ctype,
statsMap[ctype]?.capacitytotal) }} {{ $t('label.total') }}
+ {{ this.displayAllocatedCompute ? displayData(ctype,
statsMap[ctype]?.capacityallocated) : displayData(ctype,
statsMap[ctype]?.capacityused) }} {{ this.displayAllocatedCompute ?
$t('label.allocated') : $t('label.used') }} | {{ displayData(ctype,
statsMap[ctype]?.capacitytotal) }} {{ $t('label.total') }}
Review Comment:
For better readability, can we have this expression be evaluated in a
method? same above?
##########
ui/src/views/dashboard/CapacityDashboard.vue:
##########
@@ -184,15 +190,19 @@
</div>
<a-progress
status="active"
- :percent="statsMap[ctype]?.capacitytotal > 0 ? parseFloat(100.0
* statsMap[ctype]?.capacityused / statsMap[ctype]?.capacitytotal) : 0"
- :format="p => statsMap[ctype]?.capacitytotal > 0 ?
parseFloat(100.0 * statsMap[ctype]?.capacityused /
statsMap[ctype]?.capacitytotal).toFixed(2) + '%' : '0%'"
+ :percent="statsMap[ctype]?.capacitytotal > 0 ?
+ this.displayAllocatedCompute ? parseFloat(100.0 *
statsMap[ctype]?.capacityallocated / statsMap[ctype]?.capacitytotal) :
parseFloat(100.0 * statsMap[ctype]?.capacityused /
statsMap[ctype]?.capacitytotal)
+ : 0"
+ :format="p => statsMap[ctype]?.capacitytotal > 0 ?
+ this.displayAllocatedCompute ? parseFloat(100.0 *
statsMap[ctype]?.capacityallocated / statsMap[ctype]?.capacitytotal).toFixed(2)
+ '%' : parseFloat(100.0 * statsMap[ctype]?.capacityused /
statsMap[ctype]?.capacitytotal).toFixed(2) + '%'
Review Comment:
I think for better readability can we have this expression be evaluated in a
method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
