weizhouapache commented on code in PR #10208:
URL: https://github.com/apache/cloudstack/pull/10208#discussion_r1925242694
##########
api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java:
##########
@@ -103,14 +105,13 @@ public String getProtocol() {
@Override
public List<String> getSourceCidrList() {
- if (cidrlist != null) {
+ if (CollectionUtils.isNotEmpty(cidrlist) && (cidrlist.size() == 1 &&
StringUtils.isNotBlank(cidrlist.get(0)))) {
Review Comment:
I wonder if the check is correct
maybe like
```
if (CollectionUtils.isNotEmpty(cidrlist) && !(cidrlist.size() == 1
&& StringUtils.isBlank(cidrlist.get(0)))) {
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
