shwstppr commented on PR #10208:
URL: https://github.com/apache/cloudstack/pull/10208#issuecomment-2606929230

   @abh1sar API was allowing empty cidr as it takes List<String> as input,
   ```
   (qaserver) 🐱 > create firewallrule cidrlist= protocol=tcp 
ipaddressid=e7314c68-c570-42c5-939e-e61f5b30cb4b startport=22 endport=22
   {
     "firewallrule": {
       "cidrlist": "",
       "destcidrlist": "",
       "endport": 22,
       "fordisplay": true,
       "id": "2a0c6f0f-bb4c-4f2d-9c2d-1129b523f584",
       "ipaddress": "192.168.1.173",
       "ipaddressid": "e7314c68-c570-42c5-939e-e61f5b30cb4b",
       "networkid": "00089a57-3cc1-4ddc-973c-251a6f097372",
       "protocol": "tcp",
       "startport": 22,
       "state": "Active",
       "tags": [],
       "traffictype": "Ingress"
     }
   }
   ```
   I've added a check
   
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to