weizhouapache commented on code in PR #10252:
URL: https://github.com/apache/cloudstack/pull/10252#discussion_r1926755562
##########
server/src/main/java/com/cloud/bgp/BGPServiceImpl.java:
##########
@@ -255,8 +255,10 @@ public boolean allocateASNumber(long zoneId, Long
asNumber, Long networkId, Long
netName = network.getName();
}
- LOGGER.debug("Allocating the AS Number {} to {} on zone {}",
asNumber::toString,
- (Objects.nonNull(vpcId) ? "VPC " + vpc : "network " +
network)::toString,
+ VpcVO finalVpc = vpc;
Review Comment:
as we discussed privately, should they be `final` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
