nvazquez commented on code in PR #10369:
URL: https://github.com/apache/cloudstack/pull/10369#discussion_r1951947156
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -1612,6 +1614,13 @@ public Ternary<Pair<List<? extends Host>, Integer>,
List<? extends Host>, Map<Ho
logger.debug("Hosts having capacity and suitable for migration:
{}", suitableHosts);
}
+ // Only list hosts of the same architecture as the source Host in a
multi-arch zone
+ List<CPU.CPUArch> clusterArchs =
ApiDBUtils.listZoneClustersArchs(vm.getDataCenterId());
+ if (CollectionUtils.isNotEmpty(clusterArchs) && clusterArchs.size() >
1) {
+ CPU.CPUArch hostArch = srcHost.getArch();
Review Comment:
Can we remove this line and compare directly on the line below without
defining the variable?
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -44,6 +44,8 @@
import javax.inject.Inject;
import javax.naming.ConfigurationException;
+import com.cloud.cpu.CPU;
+import com.cloud.utils.security.CertificateHelper;
Review Comment:
I think this is imported but not used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
