nvazquez commented on code in PR #10042:
URL: https://github.com/apache/cloudstack/pull/10042#discussion_r1953579963
##########
ui/src/views/infra/HostEnableDisable.vue:
##########
@@ -28,15 +28,15 @@
>
<a-alert type="warning">
<template #message>
- <span v-html="$t('message.confirm.enable.host')" />
+ <span v-html="resourcestate === 'Disabled' ?
$t('message.confirm.enable.host') : $t('message.confirm.disable.host') " />
</template>
</a-alert>
- <div v-show="enableKVMAutoEnableDisableSetting" class="reason">
+ <div v-show="kvmAutoEnableDisableSetting" class="reason">
<a-form-item
class="form__item"
name="reason"
ref="reason"
- :label="'The setting \'enable.kvm.host.auto.enable.disable\' is
enabled, ' +
+ :label="'The setting \'kvm.host.auto.enable.disable\' is enabled, ' +
Review Comment:
Sorry to bother, I have just re-read the original issue and it seems to me
we can fix it without needing to update the setting name but just updating this
text and also the title as @shwstppr pointed out, leaving the setting as it
originally was. What do you think @Pearl1594 @shwstppr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
