sureshanaparti opened a new pull request, #10411:
URL: https://github.com/apache/cloudstack/pull/10411
### Description
This PR adds import/migration support for external VMware VMs in any
folders/subfolders other than the root folder ('vm') of datacenter.
<!--- Describe your changes in DETAIL - And how has behaviour functionally
changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!---
*******************************************************************************
-->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*******************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Manually tested the VMware VMs import for the VMs created in root folder
('vm'), folder & subfolder.
```
[root@kvm1 ~]# ps -ef|grep ovftool
root 38585 37625 54 16:54 ? 00:00:05
/root/ovftool/ovftool.bin --noSSLVerify
vi://administrator%40vsphere.local:P%40ssword123@10.1.33.168/Trillian/vm/fd8dda05-07f1-4160-84fa-37ec42aeff0e
/mnt/22fe2ce5-1e80-3af4-b1e5-05ffa3ad4e05/911923cb-e570-4ae9-b266-fc40030ad1e0/
root 38643 31339 0 16:54 pts/2 00:00:00 grep --color=auto ovftool
[root@kvm1 ~]# grep "VM path" /var/log/cloudstack/agent/agent.log
2025-02-17 16:54:28,826 INFO
[resource.wrapper.LibvirtConvertInstanceCommandWrapper]
(agentRequest-Handler-2:null) (logid:6c03048c) VM path: vm
[root@kvm2 ~]# ps -ef|grep ovftool
root 42230 41346 53 16:50 ? 00:00:15
/root/ovftool/ovftool.bin --noSSLVerify
vi://administrator%40vsphere.local:P%40ssword123@10.1.33.168/Trillian/vm/MyTestFolder/Test/newvm
/mnt/22fe2ce5-1e80-3af4-b1e5-05ffa3ad4e05/c28b36f7-9c55-4c67-8c5a-d139cf6fe218/
[root@kvm2 ~]# ps -ef|grep ovftool
root 42725 41346 54 16:55 ? 00:00:01
/root/ovftool/ovftool.bin --noSSLVerify
vi://administrator%40vsphere.local:P%40ssword123@10.1.33.168/Trillian/vm/MyTestFolder/testvm
/mnt/22fe2ce5-1e80-3af4-b1e5-05ffa3ad4e05/3b907bd3-2534-44ab-8ab7-3c2b7ac88688/
[root@kvm2 ~]# grep "VM path" /var/log/cloudstack/agent/agent.log
2025-02-17 16:50:26,513 INFO
[resource.wrapper.LibvirtConvertInstanceCommandWrapper]
(agentRequest-Handler-4:null) (logid:1f799005) VM path: vm/MyTestFolder/Test
2025-02-17 16:55:33,977 INFO
[resource.wrapper.LibvirtConvertInstanceCommandWrapper]
(agentRequest-Handler-4:null) (logid:ce3ee4ab) VM path: vm/MyTestFolder
```
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
