DaanHoogland commented on code in PR #9969:
URL: https://github.com/apache/cloudstack/pull/9969#discussion_r1958671628
##########
setup/bindir/cloud-setup-databases.in:
##########
@@ -229,6 +229,10 @@ for full help
"GRANT ALL ON cloud_usage.* to cloud@`%`;",
"GRANT process ON *.* TO cloud@`localhost`;",
"GRANT process ON *.* TO cloud@`%`;",
+ "IF foo > 0 THEN",
Review Comment:
I am not sure that works this way. The line `IF foo > 0 THEN` occurs 4 times
in the file create-database.sql
I think it is safer to add a line with a noop and only remove the DROP line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
