sureshanaparti commented on code in PR #10413:
URL: https://github.com/apache/cloudstack/pull/10413#discussion_r1959308254
##########
ui/src/views/tools/SelectVmwareVcenter.vue:
##########
@@ -299,18 +300,23 @@ export default {
this.hosts = response.listvmwaredchostsresponse.host
}
}).catch(error => {
- this.$notifyError(error)
+ if (doNotify) {
+ this.$notifyError(error)
+ }
+ this.hosts = []
+ return false
}).finally(() => {
this.loading = false
+ return true
Review Comment:
no need to return stmts here? @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
