This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a commit to branch netris-integration-upstream in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 03f954cbc386931164236af6dc3f1a4fb448a28e Author: Pearl Dsilva <[email protected]> AuthorDate: Thu Feb 13 11:18:53 2025 -0500 Fix the test failures noticed --- .../main/java/com/cloud/network/IpAddressManagerImpl.java | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java b/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java index 26a5505df8e..d09d6e76d11 100644 --- a/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java +++ b/server/src/main/java/com/cloud/network/IpAddressManagerImpl.java @@ -829,14 +829,12 @@ public class IpAddressManagerImpl extends ManagerBase implements IpAddressManage providers = servicesMap.stream().map(VpcOfferingServiceMapVO::getProvider).collect(Collectors.toList()); } - if (providers.isEmpty()) { - throw new InvalidParameterValueException("Unable to find the provider for this network"); - } - - String provider = providers.get(0); - NetworkElement element = _networkModel.getElementImplementingProvider(provider); - if (element != null) { - element.releaseIp(ipToBeDisassociated); + if (!providers.isEmpty()) { + String provider = providers.get(0); + NetworkElement element = _networkModel.getElementImplementingProvider(provider); + if (element != null) { + element.releaseIp(ipToBeDisassociated); + } } } finally { _ipAddressDao.releaseFromLockTable(addrId);
