DaanHoogland commented on PR #10457: URL: https://github.com/apache/cloudstack/pull/10457#issuecomment-2681308488
> @DaanHoogland the title says the PR aims to fix the merge problems, but more than 90% of this PR are related to logging yes, you are right, but these are rather safe. > > my suggestion is, revert VeeamBackupProvider.java and then cherry-pick the commit #9898 > > ``` > git checkout c80b8860e49c61252588c8cf8f40277dcf2c4ee8 plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java > git cherry-pick 21b5e4dcae5b3cb73637fc82410bd8e4fd55e99c > ``` What you suggest will not lead to a compiling version without further fixes either, neither starting on main or starting from this branch. The question is if https://github.com/apache/cloudstack/pull/10457/files#diff-35507d9957e6b1b12096c22153fc877ea347a7dd2316a0c670a0c80a6c3da3a4R330-R405 does the job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
