abh1sar commented on PR #9748:
URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2686612995

   > We discussed this internally. HyperStore does not currently support Bucket 
Quota limits. We have added an internal feature request for this which we may 
implement in a future HyperStore release. At such time, we will re-address and 
update the CloudStack HyperStore plugin bucket quota functionality. As the 
CloudStack UI and API currently both require a quota setting, we decided to 
allow the user to specify a value of 0 as the quota. The 0 quota will indicate 
no quota restriction for the bucket.
   > 
   > I rebased this branch on top of the latest main branch. I fixed 2 issues 
in commit 
[01be768](https://github.com/apache/cloudstack/commit/01be768a6955313f6e5962b6939124a97e54481c):
   > 
   > 1. The pom.xml was updated for the correct version number.
   > 2. Quota of 0 is now accepted and I added an extra test for the 0 case.
   > 
   > I built everything cleanly and tested adding a bucket successfully using a 
quota of 0. I also confirmed the error case worked with any other quota value 
and that UI shows the user the exception message to help them choose the 0 
value.
   > 
   > Please let me know if you have any questions or comments.
   
   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to