tpodowd opened a new pull request, #10551: URL: https://github.com/apache/cloudstack/pull/10551
### Description Currently, when an administrator edits an Object Storage Pool, only the name or url can be updated. This change allows the other `details` of the object store to be updated. The object store details contains the credentials used to connect to the object store as well as other information provided when it was added to the system. Only updated information is updated. The connection is tested using a new method verifyServiceConnectivity(). If no information has changed, the existing connection is also tested. In the general case (MinIO/Ceph and Simulator), this change allows you to edit the name and URL of the object storage as before in addition to the credentials used to connect to the object storage. Previously it was not possible to edit them after creation using the GUI. In the case of Cloudian HyperStore Object Storage, this allows you to additionally edit the service URL/ports. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): Before this change: <img width="1119" alt="Screenshot 2025-03-12 at 15 33 14" src="https://github.com/user-attachments/assets/e32a1ad6-7b57-44f4-a73a-2e1a3193fb21"; /> After the change: General case (editing MinIO is shown): <img width="1073" alt="Screenshot 2025-03-12 at 17 13 09" src="https://github.com/user-attachments/assets/b3081dcc-f9fb-4c6e-b176-ab95cffca3a5"; /> After the change: Cloudian HyperStore case: <img width="997" alt="Screenshot 2025-03-12 at 17 13 33" src="https://github.com/user-attachments/assets/7033c068-6db5-46d4-8c74-8124f6027102"; /> ### How Has This Been Tested? 1. Unit tests have been added for the new code where possible. 2. I tested both HyperStore and MinIO environments. I tested updating and making changes to the names, passwords, urls, ports etc and confirmed that you get feedback when the configuration is bad and it updates correctly when the configuration is good. 3. I ran all the CloudStack Unit tests with a clean build. 4. I tested adding/removing buckets after changing the object storage details. For MinIO, I created new credentials and deleted the old ones and then updated using the GUI. #### How did you try to break this feature and the system with this change? Tested as above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
