sureshanaparti commented on code in PR #10543:
URL: https://github.com/apache/cloudstack/pull/10543#discussion_r2003241627
##########
api/src/main/java/com/cloud/vm/VmDetailConstants.java:
##########
@@ -101,4 +101,13 @@ public interface VmDetailConstants {
String VMWARE_HOST_NAME = String.format("%s-host", VMWARE_TO_KVM_PREFIX);
String VMWARE_DISK = String.format("%s-disk", VMWARE_TO_KVM_PREFIX);
String VMWARE_MAC_ADDRESSES = String.format("%s-mac-addresses",
VMWARE_TO_KVM_PREFIX);
+
+ // TPM
+ String VIRTUAL_TPM_ENABLED = "virtual.tpm.enabled";
+ String VIRTUAL_TPM_MODEL = "virtual.tpm.model";
+ String VIRTUAL_TPM_VERSION = "virtual.tpm.version";
+
+ // CPU mode and model, ADMIN only
+ String GUEST_CPU_MODE = "guest.cpu.mode";
+ String GUEST_CPU_MODEL = "guest.cpu.model";
Review Comment:
can non-admin user deploy vTPM enabled instance without these settings? any
other way for the normal user to provide these options, from service offering,
etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
